(PUP-4636) Fix problem with environment.conf parser=future #3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, when the compiler was instantiated from an environment that was configured to use parser=current, the initialization of the context for compilation would do this for parser=current. This led to not having loaded the ruby code for Puppet::Pops::Loaders, and because of this, the first function call made in a puppet manifest would fail. This fixes the problem by making the compiler check if the environment it is going to *set* as the current environment has parser=future set (instead of checking in the current environment). This also moves the requirement to load the ruby logic to the loading of 'puppet/pops' since the loaders since quite some time back are lazilily initialized.
|
@hlindberg the future_parser? method is used pretty widely; are there any other cases that might require the environment to be passed in? |
|
@jpartlow I could not come up with one; it would be code that does what compile does - I am not sure we have any that does not use the compiler to uh... compile. Tests that do not use the compiler are forced to do all required setup on their own. |
|
CLA signed by all contributors. |
thallgren
added a commit
that referenced
this pull request
May 21, 2015
…etting_not_honoured (PUP-4636) Fix problem with environment.conf parser=future
hlindberg
deleted the
PUP-4636_environment_parser_setting_not_honoured
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, when the compiler was instantiated from an environment that
was configured to use parser=current, the initialization of the context
for compilation would do this for parser=current. This led to not having
loaded the ruby code for Puppet::Pops::Loaders, and because of this, the
first function call made in a puppet manifest would fail.
This fixes the problem by making the compiler check if the environment
it is going to set as the current environment has parser=future set
(instead of checking in the current environment).
This also moves the requirement to load the ruby logic to the loading of
'puppet/pops' since the loaders since quite some time back are lazilily
initialized.