(PUP-4698) Change fqdn_rand's return type to Integer #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, fqdn_rand always returned a String. That is not the best choice for a numeric value now that the evaluator is aware of different data types as comparissons will typically be wrong (since '2' > '19' when compared leicographically). This fix adds a utility method that returns an integer version while the old utility method producing a string is retained for those that use Puppet as an API. The function now uses the integer version of this utility method. A test is added that asserts that an Integer is produced. At some point it would be beneficial to reimplement the function using the 4.x function API as it will simply raise a generic error if given input of the wrong type. It will also magically change a floating point input value to integer.
|
App Veyor failing with known issues regarding rdoc |
|
CLA signed by all contributors. |
| it "returns an integer" do | ||
| expect(fqdn_rand(3)).to satisfy {|n| n.is_a?(Integer) } | ||
| end | ||
|
|
||
| it "provides a random number strictly less than the given max" do | ||
| expect(fqdn_rand(3)).to satisfy {|n| n.to_i < 3 } |
|
Other than that one nit in the spec, I'm 👍 |
|
And appveyor failures are the usual rdoc ones. Known bogo-failure. |
|
|
||
|
|
||
| it "returns an integer" do | ||
| expect(fqdn_rand(3)).to satisfy {|n| n.is_a?(Integer) } |
There was a problem hiding this comment.
Simpler as expect(fqdn_rand(3)).to be_a(Integer)
|
ok - two nits - will update |
* no need to convert to integer in test asserts since fqdn now returns and integer * simplified assert using be_an instead of satisfies
thallgren
added a commit
that referenced
this pull request
Jun 11, 2015
…n-numric (PUP-4698) Change fqdn_rand's return type to Integer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, fqdn_rand always returned a String. That is not the best
choice for a numeric value now that the evaluator is aware of different
data types as comparissons will typically be wrong (since '2' > '19'
when compared leicographically).
This fix adds a utility method that returns an integer version while the
old utility method producing a string is retained for those that use
Puppet as an API. The function now uses the integer version of this
utility method.
A test is added that asserts that an Integer is produced.
At some point it would be beneficial to reimplement the function using
the 4.x function API as it will simply raise a generic error if given
input of the wrong type. It will also magically change a floating point
input value to integer.