(PUP-5032) Change configured_environment behavior #4152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @pcarlisle @reidmv |
|
👍 |
MikaelSmith
changed the title
Puppet's communication with the node and catalog terminus included a configured_environment option in the last release. That option sometimes includes redundant or irrelevant information when `Puppet[:environment]` has the default setting. That redundant information precludes it from being used to identify when an agent has explicitly requested a particular environment. Change the behavior of configured_environment to only be set when the `environment` setting is explicitly set.
MikaelSmith
force-pushed
the
configured_environment
branch
from
ae55d65
to
3208808
Compare
| expect(@settings.set_by_config?(:myval)).to be_truthy | ||
| end | ||
|
|
||
| it "should not identify configured settings from environment" do |
There was a problem hiding this comment.
This one's interesting, but made sense for the methods use in setting agent_specified_environment. We wouldn't expect the environment.conf to specify an environment.
In general, it would make sense to extend set_by_config? to take an environment argument as an option.
added 2 commits
August 12, 2015 15:54
When `set_by_config?` was implemented, spec tests for its functionality were overlooked. Add some now.
Without this change, `set_by_config?` will ignore settings in the current environment's config file and only examines the preferred run mode. With this change, it allows environment and run_mode to be specified as arguments.
MikaelSmith
force-pushed
the
configured_environment
branch
from
3208808
to
097ef41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet's communication with the node and catalog terminus included a
configured_environment option in the last release. That option sometimes
includes redundant or irrelevant information when
Puppet[:environment]has the default setting. That redundant information precludes it from
being used to identify when an agent has explicitly requested a
particular environment.
Change the behavior of configured_environment to only be set when the
environmentsetting is explicitly set.