(PUP-3953) single quotes in titles are escaped correctly #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if you had a single quote in a resources' title, running puppet resource would generate an invalid manifest. Now, we escape any single quotes correctly.
royosherove
force-pushed
the
ticket/master/pup-3953-fix-single-quotes-to-manifest
branch
from
6d41a54
to
8de55e5
Compare
|
Looks good, added to next sprint |
|
Awesome! On Tue, Oct 13, 2015 at 12:55 PM, Josh Cooper notifications@github.com
Thanks, Roy Osherove
|
joshcooper
added a commit
that referenced
this pull request
Oct 14, 2015
…single-quotes-to-manifest (PUP-3953) single quotes in titles are escaped correctly
|
Thank you @royosherove for your contribution! This will be released in puppet 4.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you had a single quote in a resources' title,
running puppet resource would generate an invalid manifest.
Now, we escape any single quotes correctly.