(PUP-5824) Support empty interpolation in Hiera data provider #4637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, an empty interpolation such as `%{}` was not considered
an interpolation at all. The interpolation regexp required at least one
character between the curly braces.
This commit will allow the empty interpolation and will also ensure
that the expression between the curly braces is trimmed from whitespace
at both ends. If the result of that trim yields the empty string or
a string that only contains a name separator '::', then the interpolated
result will be the empty string.
It is still possible to have interpolated expressions where the key has
leading or trailing whitespace by using the function syntax, e.g.
%{hiera(' key ')}.
hlindberg
added a commit
that referenced
this pull request
Feb 5, 2016
…of-empty-variable (PUP-5824) Support empty interpolation in Hiera data provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, an empty interpolation such as
%{}was not consideredan interpolation at all. The interpolation regexp required at least one
character between the curly braces.
This commit will allow the empty interpolation and will also ensure
that the expression between the curly braces is trimmed from whitespace
at both ends. If the result of that trim yields the empty string or
a string that only contains a name separator '::', then the interpolated
result will be the empty string.
It is still possible to have interpolated expressions where the key has
leading or trailing whitespace by using the function syntax, e.g.
%{hiera(' key ')}.