(PUP-5973) Remove symbol string monkey patch #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a conditional monkey patch of Symbol#intern. This is no longer needed since all Ruby versions from 1.9.3 supports this method. It was missing on Ruby 1.8.7 which is no longer supported in the Puppet code base. The monkey patch can therefore safely be removed without any consequences.
This removes the monkey patch that made it possible to compare strings with symbols as if symbols are strings. That was problematic for many reasons (see ticket). The monkey patch is removed to prevent further accidental issues that are very hard to track down. Anyone relying on the monkey patched Symbol have been warned with a deprecation warning in earlier versions.
|
CLA signed by all contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.