(PUP-7807) Add mount options on AIX remount #6105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the mount resource on AIX would not remount NFS shares with the mount options specified. Since AIX did not read the NFS options from the `/etc/filesystems`, the share would be remounted without options. This commit adds a simple check to ensure all AIX remounts are done with the specified options including JFS2.
|
Waiting for CLA signature by @jarretlavallee @jarretlavallee - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/ Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html |
|
CLA signed by all contributors. |
|
hi @jarretlavallee, thanks for your submission! I've taken your code into #6283, which adds a test and helps out with some of the duplication. |
|
superseded by #6283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the mount resource on AIX would not remount NFS
shares with the mount options specified. Since AIX did not read the NFS
options from the
/etc/filesystems, the share would be remountedwithout options.
This commit adds a simple check to ensure all AIX remounts are done with
the specified options including JFS2.