(PUP-4918) rotate instead of reload for logrotate
#6301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ext/redhat/logrotate: really avoid 'service puppet reload' in favor of 'service puppet rotate' with the correct signal It looks like there was an intention to introduce this fix in 793d713 '(PUP-4918) Updated logrotate and init scripts', where the "rotate" command was added to ext/redhat/client.init specifically for this purpose. This doesn't apply to ext/debian/puppet.logrotate because ext/debian/puppet.init lacks a special command with this signal.
justinstoller
approved these changes
Oct 24, 2017
|
yeah this would basically be only for folks still running passenger |
|
CLA signed by all contributors. |
imz
referenced
this pull request
in imz/puppet
Dec 24, 2019
…f 'service puppet rotate' with the correct signal It looks like there was an intention to introduce this fix in 793d713 '(PUP-4918) Updated logrotate and init scripts', where the "rotate" command was added to ext/redhat/client.init specifically for this purpose. This doesn't apply to ext/debian/puppet.logrotate because ext/debian/puppet.init lacks a special command with this signal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the content of #5708, with the commit message amended per contributing guidelines.
From that PR: