Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PUP-9653) Refactor tests using uneeded master #7512

Closed
wants to merge 18 commits into from
Closed

(PUP-9653) Refactor tests using uneeded master #7512

wants to merge 18 commits into from

Commits on Jun 19, 2019

  1. (PUP-9653) Refactor agent_disable_lockfile test 

    This commit refactors the agent_disable_lockfile test:

1. Remove the use of `with_puppet_running_on` since this test does not
   test server functionality.
2. Use the block style for `test_name` in accordance with the
   [beaker style guide](https://github.com/puppetlabs/beaker/blob/master/docs/concepts/style_guide.md)

[skip ci]
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    f87ba04 View commit details
    Browse the repository at this point in the history

  2. (PUP-9653) Refactor fallback_to_cached_catalog tst 

    This commit refactors the agent fallback to cached catalog acceptance
test to use a catalog fixture rather than using a master to see the
catalog cache.  This removes the need to manage the puppet master, so
the use of `with_puppet_running_on` has been deleted.

[skip ci]
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    5adc5d0 View commit details
    Browse the repository at this point in the history

  3. (PUP-9653) Refactor v4_hieradata_with_v5_configs tst 

    This commit refactors the `v4_hieradata_with_v5_configs` acceptance
test to use `puppet apply` rather than `puppet agent` to ensure
that the appropriate hiera data is looked up for environments.  This
removes the dependence on a master, so the `with_puppet_running_on`
block has been removed.
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    c4826b8 View commit details
    Browse the repository at this point in the history

  4. (PUP-9653) Refactor modules/changes/missing_checks 

    This commit refactors the `modules/changes/missing_checksums_json`
acceptance test to run on agents rather than using a master.  The
test has also been updated to comply with the beaker style guide.
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    003bc33 View commit details
    Browse the repository at this point in the history

  5. (PUP-9653) Refactor modules/changes/missing_metada 

    This commit refactors the `modules/changes/missing_metadata_json`
acceptance test to run on agents rather than using a master.  The
test has also been updated to comply with the beaker style guide.
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    9a17e5b View commit details
    Browse the repository at this point in the history

  6. (PUP-9653) Refactor modules/changes/removed_file 

    This commit refactors the `modules/changes/module_with_removed_file`
acceptance test to run on agents rather than using a master.  The
test has also been updated to comply with the beaker style guide.
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    18e3521 View commit details
    Browse the repository at this point in the history

  7. (PUP-9653) Refactor modules/changes/invalid_instal 

    This commit refactors the `modules/changes/invalid_module_install_path`
acceptance test to run on agents rather than using a master.  The
test has also been updated to comply with the beaker style guide.
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    6c21106 View commit details
    Browse the repository at this point in the history

  8. (PUP-9653) Refactor modules/changes/modified_file 

    This commit refactors the `modules/changes/module_with_modified_file`
acceptance test to run on agents rather than using a master.  The
test has also been updated to comply with the beaker style guide.
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    0dc9b75 View commit details
    Browse the repository at this point in the history

  9. (PUP-9653) Refactor modules/changes/unmodified_mod 

    This commit refactors the `modules/changes/unmodified_module`
acceptance test to run on agents rather than using a master.  The
test has also been updated to comply with the beaker style guide.
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    f02c2d6 View commit details
    Browse the repository at this point in the history

  10. (PUP-9653) Refactor hiera_hash/lookup_data test 

    This commit refactors the `parser_functions/hiera_hash/lookup_data`
acceptance test to run on agents rather than using a master.  The
test has also been updated to comply with the beaker style guide.
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    b3bccb2 View commit details
    Browse the repository at this point in the history

  11. (PUP-9653) Refactor puppet_lookup_cmd test 

    This commit refactors the `parser_functions/puppet_lookup_cmd`
acceptance test to run on agents rather than using a master.  The
test has also been updated to comply with the beaker style guide.
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    b47b590 View commit details
    Browse the repository at this point in the history

  12. (PUP-9653) Refactor utf8-in-puppet-describe test 

    This commit refactors the `utf8/utf8-in-puppet-describe.rb`
acceptance test to run on agents rather than using a master.  The
test has also been updated to comply with the beaker style guide.
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    f2b54a5 View commit details
    Browse the repository at this point in the history

  13. (PUP-9653) Refactor hiera_array lookup test 

    This commit refactors the `parser_functions/hiera_array/lookup_data.rb`
acceptance test to run on agents rather than using a master.  The
test has also been updated to comply with the beaker style guide.
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    7adce38 View commit details
    Browse the repository at this point in the history

  14. (PUP-9653) Refactor hiera lookup_data test 

    This commit refactors the `parser_functions/hiera/lookup_data.rb`
acceptance test to run on agents rather than using a master.  The
test has also been updated to comply with the beaker style guide.
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    5c7ead6 View commit details
    Browse the repository at this point in the history

  15. (PUP-9653) Refactor hiera_in_templates test 

    This commit refactors the `parser_functions/hiera_in_templates.rb`
acceptance test to run on agents rather than using a master.  The
test has also been updated to comply with the beaker style guide.
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    58a28fd View commit details
    Browse the repository at this point in the history

  16. (PUP-9653) Refactor catalog_uuid_correlates_catalogs_with_reports 

    This commit refactors the
`direct_puppet/catalog_uuid_correlates_catalogs_with_reports.rb`
acceptance test to run on agents rather than using a master.  The test
has also been updated to comply with the beaker style guide.
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    8ac42b3 View commit details
    Browse the repository at this point in the history

  17. (PUP-9653) Fix environmentpath in mk_tmp_env tests 

    This commit changes tests using the `mk_tmp_env` helper to introspect the
environment path from the puppet `environmentpath` rather than
hard-coding the `/tmp` directory.

This change is necessary to accommodate updates to the helper that ensure
that the `environmentpath` is updated from the temporary environment,
but that ad-hoc changes to the generated temp directory will not be
updated.  This is necessary because Windows cannot link the environment
path to the generated temp directory.
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    243005e View commit details
    Browse the repository at this point in the history

  18. (PUP-6953) Remove reference to links.puppet.com 

    This commit removes a comment reference to links.puppet.com which
is no longer available.  The desired redirection for the link is
unknown, so no replacement link has been added.
    @johnduarte
    johnduarte committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    802a486 View commit details
    Browse the repository at this point in the history