Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PUP-10235) Support enabling DNF modules #8047

Merged

Conversation

GabrielNagy
Copy link
Contributor

@GabrielNagy GabrielNagy commented Mar 19, 2020

Add an optional enable_only parameter to the package type.

If set to true on a dnfmodule resource, it will cause the module
to be enabled instead of installed. The flag cannot be set together
with the flavor property, since they conflict.

DNF modules that have no default profile (and cannot be installed)
will be enabled by default, so there is no need to add enable_only.

To enable a module that has a default profile, enabled_only has to
be set.

@GabrielNagy GabrielNagy changed the title (PUP-10235) [WIP] Support enabling/disabling DNF modules (PUP-10235) Support enabling DNF modules Mar 19, 2020
@puppetcla
Copy link

CLA signed by all contributors.

@GabrielNagy GabrielNagy force-pushed the PUP-10235/support-dnfmodule-enable branch 5 times, most recently from 167aa75 to 03d59ff Compare March 20, 2020 10:04
@GabrielNagy GabrielNagy marked this pull request as ready for review March 20, 2020 10:05
@GabrielNagy GabrielNagy requested review from a team March 20, 2020 10:05
@GabrielNagy GabrielNagy force-pushed the PUP-10235/support-dnfmodule-enable branch from 03d59ff to e39cafb Compare March 20, 2020 10:18
@GabrielNagy
Copy link
Contributor Author

Acceptance passing with: bundle exec rake ci:test:git SHA=PUP-10235/support-dnfmodule-enable RUNTIME_BRANCH=5.5.x FORK=GabrielNagy TESTS='tests/provider/package/dnfmodule_enable_only.rb' HOSTS=centos8-64a

@ciprianbadescu
Copy link
Contributor

jenkins please test this on fedora30-64a,fedora31-64a,redhat5-64a,centos6-64a,centos6-32a,centos8-64a,redhat7-64a,redhat7-POWERa,redhat7-AARCH64a,redhat8-64a,redhatfips7-64a

@GabrielNagy GabrielNagy force-pushed the PUP-10235/support-dnfmodule-enable branch 8 times, most recently from 0331c14 to 786433e Compare March 30, 2020 14:40
Add an optional `enable_only` parameter to the package type.

If set to `true` on a `dnfmodule` resource, it will cause the module
to be enabled instead of installed. The flag cannot be set together
with the `flavor` property, since they conflict.

DNF modules that have no default profile (and cannot be installed)
will be enabled by default, so there is no need to add `enable_only`.

To enable a module that has a default profile, `enabled_only` has to
be set.
@ciprianbadescu ciprianbadescu requested a review from a team March 31, 2020 06:59
Copy link
Contributor

@ciprianbadescu ciprianbadescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on CentOS 8, works as expected

@ciprianbadescu ciprianbadescu requested a review from a team March 31, 2020 07:01
@gimmyxd gimmyxd merged commit f27ab77 into puppetlabs:5.5.x Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants