Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PUP-10152) Prevent Pacman package provider doing partial upgrades #8064

Merged
merged 1 commit into from Apr 1, 2020

Conversation

PaulWalkerUK
Copy link
Contributor

Using the -y switch in Pacman refreshes the catalog, but doesn't
upgrade existing packages. This causes a "partial upgrade".
From the Arch Linux wiki: Partial upgrades are
unsupported

This change removes the -y switch. It will be up to the user to
refresh the catalog and upgrade the system explicitly. The other
approach would be to have both the -y and -u switches, but that
would mean that installing a package through Puppet would implicitly
upgrade the whole of the system - I don't think that would be desirable.

Using the `-y` switch in Pacman refreshes the catalog, but doesn't
upgrade existing packages. This causes a "partial upgrade".
From the Arch Linux wiki: [Partial upgrades are
unsupported](https://wiki.archlinux.org/index.php/System_maintenance#Partial_upgrades_are_unsupported)

This change removes the `-y` switch. It will be up to the user to
refresh the catalog and upgrade the system _explicitly_. The other
approach would be to have both the `-y` _and_ `-u` switches, but that
would mean that installing a package through Puppet would implicitly
upgrade the whole of the system - I don't think that would be desirable.
@PaulWalkerUK PaulWalkerUK requested review from a team March 30, 2020 00:30
@puppetlabs-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@puppetcla
Copy link

CLA signed by all contributors.

Copy link
Contributor

@GabrielNagy GabrielNagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍
thanks for the contribution!

@GabrielNagy GabrielNagy merged commit 83febbf into puppetlabs:master Apr 1, 2020
@PaulWalkerUK PaulWalkerUK deleted the pup-10152 branch April 2, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants