(PUP-10524) Address spec failures when running with facter 4

[melissa]

Fixes still required

• $CHILD_STATUS returns nil
• trace logging

[puppetcla]

CLA signed by all contributors.

[BogdanIrimie]

@melissa this is great!

The trace problem was fixed today in https://github.com/puppetlabs/facter-ng/pull/527/files

The test that fail with the $CHILD_STATUS error mock texecute or execute from execution.rb. Since the execution is mocked, a new process is never created and there is no exit status. It was just a coincidence that Facter 2 spawned a new process and it's exit status was interpreted as the exit status from texecute or execute

In order to fix the test we can add a before block to the test e.g

  before(:all) do
    `exit 0`
  end

With the changes from this branch, the $CHILD_STATUS fix and Facter 4 master branch, the unit test pass

Finished in 9 minutes 53 seconds (files took 8.71 seconds to load)
25800 examples, 0 failures, 39 pending

[BogdanIrimie]

@melissa I pushed the changes for $CHILD_STATUS on your branch and released Facter 4.0.23 today (with the trace fix). Puppet test should pass with these changes.

[melissa]

Thank you @IrimieBogdan ! Could you add a comment to the code here explaining why we have to do this? I can see someone getting really confused a year from now as to why this is needed :)

[BogdanIrimie]

Added a comments describing the fix and why it is required.

[puppetcla]

CLA signed by all contributors.