(PUP-10845) Eliminate keyword parameter warning #8467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppet emitted a deprecation warning when parsing a `node` definition containing a hostname, because it passed a hash to `Puppet::Parser::AST::HostName.new`, but the initialize method expected keyword arguments. The error is only reproducible using ruby 2.7.1, but not 2.7.2. The error doesn't happen with `AST::Regex`, because its `initialize` method accepted a hash. This commit double splats the hash prior to calling `klass.new` and it updates `AST::Regex` to expect keyword arguments like `AST::HostName`. Note the superclass `AST::Leaf` already expects keyword arguments.
|
I targeted 6.x because we test against 2.7 in CI and that's where the other keyword changes were made. |
gimmyxd
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet emitted a deprecation warning when parsing a
nodedefinition containinga hostname, because it passed a hash to
Puppet::Parser::AST::HostName.new, butthe initialize method expected keyword arguments. The error is only reproducible
using ruby 2.7.1, but not 2.7.2. The error doesn't happen with
AST::Regex,because its
initializemethod accepted a hash.This commit double splats the hash prior to calling
klass.newand it updatesAST::Regexto expect keyword arguments likeAST::HostName. Note thesuperclass
AST::Leafalready expects keyword arguments.