(PUP-7799) Allow searching for resources #8631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit ef12173 renamed the Puppet::Resource#to_resource method, but it wasn't caught here due to overstubbing. This commit updates the tests and marks two of the test as pending.
Searching for instances of a particular type in the request key or as an indirector request option didn't work because the Puppet::Resource#to_resource method was renamed. Update it to call the correct method.
joshcooper
force-pushed
the
ral_search_7799
branch
from
7f0c6ee
to
445d1e7
Compare
GabrielNagy
approved these changes
Jun 14, 2021
|
jenkins please test this with servertests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit ef12173 renamed the
Puppet::Resource#to_resourcemethod, which broke theralterminus, but it went unnoticed due to overstubbing in the test. This cleans up the tests and makes it possible to once again filter resources either using the keyPuppet::Resource.indirection.search('user/root')or using optionsPuppet::Resource.indirection.search('user', name: 'root')