(PUP-5704) allow array commands in exec resource #8660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielNagy
reviewed
Jun 28, 2021
felixdoerre
reviewed
Jun 29, 2021
GabrielNagy
reviewed
Jun 29, 2021
joshcooper
reviewed
Jun 29, 2021
joshcooper
reviewed
Jun 29, 2021
joshcooper
approved these changes
Jun 29, 2021
This change updates the exec resource to accept arrays as command. The new behaviour is enabled for the following parameters: `:comand`, `:onlyif`, `:unless`, `:refresh`. ``` Changing the command to accept an array: command: "/bin/echo *" # executes through shell command: ["/bin/echo *"] # non-existing command "bin/echo *" command: ["/bin/echo *", "*"] # non-existing command "bin/echo *" command: ["/bin/echo", "*"] # executes directly onlyif/unless: '/bin/echo *' # executes one command through shell onlyif/unless: ['/bin/echo *', '/bin/echo $SHELL'] # executes two commands through shell onlyif/unless: [["/bin/echo", "*"]] # executes one command directly onlyif/unless: [["/bin/echo", "*"], ["/bin/echo", "$SHELL"]] # executes two commands directly ```
GabrielNagy
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the exec resource to accept arrays as command.
The new behavior is enabled for the following parameters:
:comand,:onlyif,:unless,:refresh.