Support uninstall_options for gem package resource like for install_options

[brandsr]

The attribute install_options for the gem package resource is included before the gemname to install. While the uninstall_options are included after the gemname ... This is faulty. For now I have modified the uninstall_options to use the same login as for install_options.

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[joshcooper]

Hi @brandsr thank you for your contribution! Do uninstall options not work because the gem provider is including them after the gem name, like gem uninstall <name> --param value? Do you have a scenario where this causes a failure, or did you want to make it consistent with install options?

To get this merged, could you:

1. Create a JIRA ticket in the PUP project: https://tickets.puppetlabs.com/projects/PUP
2. Describe the expected and actual behavior
3. Prefix the subject line in your commit message with the ticket, e.g. (PUP-123) ...
4. Update the tests in spec/unit/provider/package/gem_spec.rb as needed.
5. Sign the CLA

Thank you!

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[joshcooper]

Hi @brandsr not sure if you saw my earlier comments? Also is there a particular case where the ordering of uninstall_options was causing problems or was it just inconsistent with respect to install_options?

[joshcooper]

Hi @brandsr not sure if you saw my comment. What did you mean by "While the uninstall_options are included after the gemname ... This is faulty." Can you give an example of what was faulty? If we don't hear back in the next few weeks, then we'll need to close this out.