(PUP-11764) Convert module beaker tests to integration tests #9025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhashizume
reviewed
Mar 3, 2023
Comment on lines
1
to
11
| name 'pmtacceptance/nginx' | ||
| version '0.0.1' | ||
| source 'UNKNOWN' | ||
| author 'pmtacceptance' | ||
| license 'UNKNOWN' | ||
| summary 'UNKNOWN' | ||
| description 'UNKNOWN' | ||
| project_page 'UNKNOWN' | ||
|
|
||
| ## Add dependencies, if any: | ||
| # dependency 'username/name', '>= 1.2.0' |
There was a problem hiding this comment.
I don't recognize this Modulefile pattern, is this a legacy convention for Puppet modules? Is this something we can drop?
There was a problem hiding this comment.
ah I downloaded the pmtacceptance-nginx module from the test forge that we had been using in beaker tests and added it as test fixture
joshcooper
force-pushed
the
convert_module_tests
branch
8 times, most recently
from
78e83e0
to
c51fe6f
Compare
Adds a subset of the files from the pmtacceptance-nginx module from the test forge. The github action `actions/checkout@v3` will by default convert NL to CRNL on Windows, unless disabled in git config. This commit disables text mode (-text) for those files in .gitattributes. This is necessary, because future commits will need to `puppet module changes` to compare the modules' files on disk against the `checksums` hash in metadata.json.
puppet-agent already tests that the agent can connect to the forge to verify TLS compatibility and that the forge cert is trusted by the agent's CA bundle.
Also delete last remnants of the test forge
joshcooper
force-pushed
the
convert_module_tests
branch
from
c51fe6f
to
6c49620
Compare
mhashizume
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove our dependency on the test forge.
Convert beaker tests to rspec integration tests.