(PUP-11897) Handle EOF in order to avoid busy-loop #9074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When EOF is reached, calls to IO.select() will return immediately, resulting in puppet executing the loop without any internal blocking. This causes up to 100% usage of a CPU core until the child finishes. If the child does its own stdout/stderr redirection before a long operation, for example, this can result in much wasted CPU usage. There is no need to execute the body of the loop after EOF is reached, so switch the Process.waitpid2 flags to block.
|
Can one of the admins verify this patch? |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When EOF is reached, calls to IO.select() will return immediately, resulting in puppet executing the loop without any internal blocking. This causes up to 100% usage of a CPU core until the child finishes.
If the child does its own stdout/stderr redirection before a long operation, for example, this can result in much wasted CPU usage.
There is no need to execute the body of the loop after EOF is reached, so switch the Process.waitpid2 flags to block.