(PUP-11937) Skip autorequire if exec's param is deferred and lazily evaluated #9152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…valuated If an exec's 'command' parameter is deferred and lazily evaluated, then we can't autorequire the file that the command will execute. This is because we won't know what the command will be until the exec is evaluated. But that means it's already too late to add a relationship from the file resource to the exec resource. In this situation an explicit relationship must be added to ensure the file resource is evaluated before the exec. The same is true for the 'onlyif' and 'unless' exec parameters.
cthorn42
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an exec's 'command' parameter is deferred and lazily evaluated, then we can't autorequire the file that the command will execute. This is because we won't know what the command is until the exec is evaluated. But that means it's already too late to add a relationship from the file resource to the exec resource. In this situation and explicit relationship is required to ensure the file resource is evaluated before the exec. The same is true for the 'onlyif' and 'unless' exec parameters.