Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document passing an array to exec creates #9167

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

yakatz
Copy link
Contributor

@yakatz yakatz commented Nov 22, 2023

This is probably not what most people would expect...

This is probably not what most people would expect...
@yakatz yakatz requested a review from a team as a code owner November 22, 2023 14:34
@puppetlabs-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@yakatz
Copy link
Contributor Author

yakatz commented Nov 22, 2023

Hopefully #9168 can be changed instead and the documentation updated to match that.

@joshcooper
Copy link
Contributor

Thank you @yakatz I think it makes sense to merge this as-is, since it documents the current behavior. And we can investigate your proposal for changing the behavior separately. I'm going to close and reopen this PR so that the GH checks run (we've updated them since this PR was opened)

@joshcooper joshcooper closed this Apr 10, 2024
@joshcooper joshcooper reopened this Apr 10, 2024
@joshcooper joshcooper merged commit a62d774 into puppetlabs:main Apr 10, 2024
9 checks passed
@joshcooper joshcooper added the bug Something isn't working label Apr 10, 2024
@yakatz yakatz deleted the patch-1 branch April 10, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants