Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-1243) - Skip tear_down if no provisioner found #512

Merged
merged 1 commit into from Jul 25, 2023

Conversation

jordanbreen28
Copy link
Contributor

Summary

If no provisioner fact is present, skip tearing down and move on to next node.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Fixes #421

Checklist

  • 馃煝 Spec tests.
  • 馃煝 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner July 25, 2023 10:11
@jordanbreen28 jordanbreen28 force-pushed the CONT-1243-fix_tear_down_with_no_provisioner branch from 8a8855b to 466b237 Compare July 25, 2023 10:13
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit e6965b8 into main Jul 25, 2023
3 checks passed
@LukasAud LukasAud deleted the CONT-1243-fix_tear_down_with_no_provisioner branch July 25, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

litmus:tear_down fails for inventories with nodes that don't have a provisioner fact.
2 participants