Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature) matrix from metadata v3 #549

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Feb 13, 2024

another matrix generator with a focus on flexibility.

  • matrix.json is the configuration for supported provisioners and collections.
  • runners are now part of the matrix, the key github_runners is a hash of provisioners, each with a hash of regex to runner name maps.
  • disable provision_service if not in the puppetlabs org
  • special hidden flag --puppetlabs to enable the provision_service even if the repo is not in the puppetlabs org

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.95%. Comparing base (c541934) to head (aa18224).

Current head aa18224 differs from pull request most recent head 654c713

Please upload reports for the commit 654c713 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage   63.95%   63.95%           
=======================================
  Files           6        6           
  Lines         763      763           
=======================================
  Hits          488      488           
  Misses        275      275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h0tw1r3 h0tw1r3 force-pushed the matrix-v3 branch 8 times, most recently from 9722679 to 13f1d79 Compare April 27, 2024 03:12
@h0tw1r3 h0tw1r3 marked this pull request as ready for review April 27, 2024 03:14
@h0tw1r3 h0tw1r3 requested a review from a team as a code owner April 27, 2024 03:14
@h0tw1r3 h0tw1r3 force-pushed the matrix-v3 branch 2 times, most recently from a29085b to dabb146 Compare May 7, 2024 04:29
@h0tw1r3 h0tw1r3 force-pushed the matrix-v3 branch 5 times, most recently from a50d1e6 to aa18224 Compare May 7, 2024 05:07
@LukasAud
Copy link
Contributor

Awaiting docs update before merging.

@h0tw1r3 h0tw1r3 force-pushed the matrix-v3 branch 2 times, most recently from cb6eae9 to e7bb4f1 Compare May 31, 2024 02:32
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented May 31, 2024

@puppetlabs/devx docs complete, ready for merge

@gavindidrichsen gavindidrichsen changed the title (maint) matrix from metadata v3 (feature) matrix from metadata v3 Jun 6, 2024
Copy link
Contributor

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work @h0tw1r3 , thanks!

@gavindidrichsen gavindidrichsen merged commit cce4641 into puppetlabs:main Jun 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants