Import sar data files #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
May 24, 2023
files/Postgresql_performance.json
Outdated
| @@ -24,7 +24,8 @@ | |||
| "editable": true, | |||
| "fiscalYearStartMonth": 0, | |||
| "graphTooltip": 1, | |||
| "id": 38, | |||
| "id": 3, | |||
There was a problem hiding this comment.
are the changes here actually related to the PR?
There was a problem hiding this comment.
I should have made a note about that, but the current Postgres dashboard has a misconfig where there's a default selection for the database sizes panel, so nothing shows up by default. I snuck that fix in here.
There was a problem hiding this comment.
I think it makes sense to pull that into another PR. you are now mixing an rnhancement with a bugfix in the same PT and commit. so reverting the enhancement will introduce a regression. And the dashboard fiy wont show up in the changelog.
There was a problem hiding this comment.
Agreed, I took it out of this PR.
MartyEwings
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.