Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#74) collect local PCP metrics #179

Merged
merged 3 commits into from Jun 16, 2023
Merged

Conversation

bastelfreak
Copy link
Collaborator

also includes #178

spec/classes/agent_spec.rb Outdated Show resolved Hide resolved
@bastelfreak
Copy link
Collaborator Author

@m0dular any chance you can test that? The telegraf agents at my PE customer start now and have the PCP configs. telegraf also doesn't log any errors. But I poked influxdb via grafana and checked for puppetlabs.pcp.connections metrics and didn't find anything. Maybe I did it wrong or maybe something else is missing.

@m0dular
Copy link
Collaborator

m0dular commented Jun 14, 2023

Works for me. I used your pcp branch, set puppet_operational_dashboards::telegraf::agent: local, and all the expected config was there. Testing it manually works

$ telegraf --test --debug --config /etc/telegraf/telegraf.conf --config /etc/telegraf/telegraf.d/pcp_metrics.conf

> orchestrator,host=pe-server-e5a7ce-0,mbean=default:name\=puppetlabs.pcp.connections,url=https://pe-server-e5a7ce-0.us-west1-a.c.customer-support-scratchpad.internal:8143/metrics/v2/read/default:name\=puppetlabs.pcp.connections Value=2 1686767303000000000

as does the service. I'm able to see a Value field for the default:name=puppetlabs.pcp.connections mbean under the orchestrator measurement.

@bastelfreak
Copy link
Collaborator Author

ah I had the wrong measurement. perfect. I think the sles errors aren't related? Can this be merged?

@MartyEwings MartyEwings requested a review from m0dular June 16, 2023 09:48
@MartyEwings MartyEwings dismissed m0dular’s stale review June 16, 2023 09:50

the issue was resolved

@MartyEwings MartyEwings merged commit e5c3a0b into puppetlabs:main Jun 16, 2023
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants