Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puppet/telegraf: Require 5.x; puppetlabs/stdib: Require 9.x #181

Merged
merged 3 commits into from Aug 4, 2023

Conversation

bastelfreak
Copy link
Collaborator

Starting with puppet/telegraf 5 the toml-rb gem isn't required anymore. This requires puppetlabs/stdib 9.

@MartyEwings
Copy link
Collaborator

@bastelfreak maybe we should remove the toml gem from acceptance testing as part of this PR to make sure it all works as expected

@bastelfreak
Copy link
Collaborator Author

@MartyEwings the influxdb module still requires the toml gem :( The telegraf module also has acceptance tests and we dropped the toml gem theree.

@MartyEwings
Copy link
Collaborator

darn it i forgot about that

@bastelfreak
Copy link
Collaborator Author

@MartyEwings do you have an idea where the error is coming from? 🤔

@m0dular
Copy link
Collaborator

m0dular commented Aug 3, 2023

Forgot about this one, sorry about that. I kicked it because the errors were provisioning related, now we're getting spec test errors because of the new influxdb release:

'influxdb::retrieve_token' expects 4 arguments, got 3

I think I messed up not making the new parameter to the function optional. #185 is passing because I accounted for the new param, but maybe we should see if we can make the parameter optional and cut a new release? We shouldn't break existing usage of the function.

@m0dular
Copy link
Collaborator

m0dular commented Aug 3, 2023

I opened #95 there to resolve that.

Starting with this version the toml-rb gem isn't required anymore.
This is required for the new puppet/telegraf version.
@bastelfreak
Copy link
Collaborator Author

@m0dular I rebased this one.

@m0dular m0dular merged commit c4b4b76 into puppetlabs:main Aug 4, 2023
23 of 25 checks passed
@bastelfreak
Copy link
Collaborator Author

thanks for merging! can you do a new release soonish please?

@bastelfreak bastelfreak deleted the telegraf5 branch August 4, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants