New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
puppet/telegraf: Require 5.x; puppetlabs/stdib: Require 9.x #181
Conversation
@bastelfreak maybe we should remove the toml gem from acceptance testing as part of this PR to make sure it all works as expected
|
@MartyEwings the influxdb module still requires the toml gem :( The telegraf module also has acceptance tests and we dropped the toml gem theree. |
darn it i forgot about that |
@MartyEwings do you have an idea where the error is coming from? 🤔 |
Forgot about this one, sorry about that. I kicked it because the errors were provisioning related, now we're getting spec test errors because of the new
I think I messed up not making the new parameter to the function optional. #185 is passing because I accounted for the new param, but maybe we should see if we can make the parameter optional and cut a new release? We shouldn't break existing usage of the function. |
I opened #95 there to resolve that. |
Starting with this version the toml-rb gem isn't required anymore.
This is required for the new puppet/telegraf version.
@m0dular I rebased this one. |
thanks for merging! can you do a new release soonish please? |
Starting with puppet/telegraf 5 the toml-rb gem isn't required anymore. This requires puppetlabs/stdib 9.