Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic to include pe metrics #204

Merged
merged 1 commit into from Jan 25, 2024

Conversation

m0dular
Copy link
Collaborator

@m0dular m0dular commented Jan 9, 2024

This commit updates the $include_pe_metrics to use a selector instead of a regex. This prevents an error when the $settings::module_groups evaluates to nil, such as when using puppet apply.

This commit updates the $include_pe_metrics to use a selector instead of
a regex.  This prevents an error when the $settings::module_groups
evaluates to nil, such as when using `puppet apply`.
@m0dular m0dular requested review from bastelfreak and a team as code owners January 9, 2024 22:25
Copy link
Contributor

@Aaronoftheages Aaronoftheages left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic Fix looks good - Approved.

@Aaronoftheages Aaronoftheages added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request bug Something isn't working labels Jan 25, 2024
@Aaronoftheages Aaronoftheages merged commit d648b6a into puppetlabs:main Jan 25, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants