Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SUP-3201) Make Grafana datasource idempotent #30

Merged
merged 2 commits into from Apr 21, 2022

Conversation

m0dular
Copy link
Collaborator

@m0dular m0dular commented Apr 12, 2022

Prior to this commit, using the grafana_datasource resource with "secure
json" parameters was not idempotent. This is because the api obfuscates
these values, so we can't check the state of the datasource using this
resource.

This commit uses the "provisioning" directory to set the datasource at
service startup. It uses a template to create the file so the token can
be a Sensitive type and be redacted from logs and reports.

It also adds an exec to make sure Grafana is ready to accept
connections.

Prior to this commit, using the grafana_datasource resource with "secure
json" parameters was not idempotent.  This is because the api obfuscates
these values, so we can't check the state of the datasource using this
resource.

This commit uses the "provisioning" directory to set the datasource at
service startup.  It uses a template to create the file so the token can
be a Sensitive type and be redacted from logs and reports.

It also adds an exec to make sure Grafana is ready to accept
connections.
@m0dular m0dular requested a review from a team as a code owner April 12, 2022 17:40
@puppet-community-rangefinder
Copy link

puppet_operational_dashboards is a class

that may have no external impact to Forge modules.

puppet_operational_dashboards::profile::dashboards is a class

that may have no external impact to Forge modules.

puppet_operational_dashboards::telegraf::agent is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@m0dular m0dular merged commit b695fd9 into main Apr 21, 2022
@MartyEwings MartyEwings added the bug Something isn't working label Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants