This repository has been archived by the owner on Jan 22, 2024. It is now read-only.
(PDB-2940) fix utf8 handling #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| while reader.read(&mut buf).unwrap() != 0 { | ||
| writer.write(&mut buf); | ||
| } |
There was a problem hiding this comment.
I think you're wanting to do something like
let stdout = io::stdout();
let mut handle = stdout.lock();
io::copy(&mut res, &mut handle).ok().expect("failed to write response");And you could wrap the resp in a BufReader if you wanted!
Remove beautician dependency and pass pretty-printed output from the API straight to stdout. This simplifies the code a bit and gets us around a beautician bug that caused us to mishandle UTF8 in CLI results.
wkalt
force-pushed
the
maint/stable/pdb-2940-fix-utf8-handling
branch
from
173379f
to
3ed4bd0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove beautician dependency and pass pretty-printed output from the API
straight to stdout. This simplifies the code a bit and gets us around a
beautician bug that caused us to mishandle UTF8 in CLI results.