Cleanup ruby code via rubocop #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will add code cleanup as corrected and alerted by rubocop. It also adds rules to execute rubocop on Travis.
pmcmaw
reviewed
Nov 14, 2017
| @@ -1,4 +1,4 @@ | |||
| #This file is generated by ModuleSync, do not edit. | |||
| # This file is generated by ModuleSync, do not edit. | |||
There was a problem hiding this comment.
Any changes in this file will be overwritten when a module sync is ran, I would suggest making the changes in the modulesync configs: https://github.com/puppetlabs/modulesync_configs/blob/master/moduleroot/spec/spec_helper.rb
There was a problem hiding this comment.
This change was made to modulesync
|
One minor comment, otherwise LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will add code cleanup as corrected
and alerted by rubocop. It also adds rules to
execute rubocop on Travis.