Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODULES-1744: use bool2httpd for server_signature and trace_enable #1006

Merged
merged 1 commit into from
Feb 4, 2015

Conversation

jlambert121
Copy link
Contributor

No description provided.

@hunner
Copy link
Contributor

hunner commented Feb 4, 2015

Perhaps instead we should validate that they are actually on/off, as in https://github.com/puppetlabs/puppetlabs-apache/blob/1.2.0/manifests/init.pp#L101 ?

@hunner
Copy link
Contributor

hunner commented Feb 4, 2015

As the readme would indicate that those are the values that SHOULD be passed, though not explicitly https://github.com/puppetlabs/puppetlabs-apache#trace_enable https://github.com/puppetlabs/puppetlabs-apache#server_signature

@jlambert121
Copy link
Contributor Author

I thought about validating, but the function already existed so I went with more options for the user. I'm happy to switch it out for validation, bools make more sense to me though.

On Feb 4, 2015, at 14:52, Hunter Haugen notifications@github.com wrote:

Perhaps instead we should validate that they are actually on/off, as in https://github.com/puppetlabs/puppetlabs-apache/blob/1.2.0/manifests/init.pp#L101 ?


Reply to this email directly or view it on GitHub.

hunner added a commit that referenced this pull request Feb 4, 2015
MODULES-1744: use bool2httpd for server_signature and trace_enable
@hunner hunner merged commit c1c4eae into puppetlabs:master Feb 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants