Include apache::params in apache::mod::php

[reidmv]

The apache::mod::php class makes reference to a params variable but does not explicitely include the apache::params class. Parse order can result in not having the appropriate variable available and a file /php5.conf being created and managed. This commit resolves the problem by adding an explicity include apache::params line to apache::mod::php.

[hunner]

I guess it was assumed that the base apache class would be included 100% of the time that any of the sub-classes or defined resources are used, but okay.

[reidmv]

In the case where I was running into problems the base apache class was never explicitly included in user manifests. The user manifests simply made use of apache::vhost defined resources which when parsed will include apache. So the following would have been valid but would have broken:

class role::foo {
  include apache::mod::php

  apache::vhost { '*':
    priority => '00',
    port     => '80',
    docroot  => '/srv/www/default',
  }

}

[hunner]

Yeah. This goes back to whether using any <module>::* pieces should require include <module> base class for bootstrapping or not. But the path-of-least-surprise also applies.

[hunner]

For reference: https://github.com/puppetlabs/puppetlabs-apache/blob/master/CHANGELOG#L1