Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make $lib_path configurable #1057

Merged
merged 1 commit into from
Apr 10, 2015
Merged

make $lib_path configurable #1057

merged 1 commit into from
Apr 10, 2015

Conversation

fraenki
Copy link
Contributor

@fraenki fraenki commented Mar 9, 2015

In conjunction with ${apache::apache_version} it is sometimes required to also change $lib_path to a non-default location. This patch introduces lib_path as a new parameter.

@igalic
Copy link
Contributor

igalic commented Mar 9, 2015

are those uses in mod_wsgi and mpm the only ones?
should we generally make this a template for modules?

@bmjen
Copy link
Contributor

bmjen commented Mar 26, 2015

Please add a test for the new param.

@cmurphy
Copy link
Contributor

cmurphy commented Mar 26, 2015

I don't think there's an especially obvious place to add a test for this, and I'd be fine with going without. I would still like to see @igalic's questions answered.

@underscorgan
Copy link
Contributor

@fraenki ping?

@fraenki
Copy link
Contributor Author

fraenki commented Apr 9, 2015

@igalic These are the only occurences of ::apache::params::lib_path. I don't think there's more to do here, since this is a somewhat special use-case.
@mhaskel Sorry for my late reply. :-(

igalic added a commit that referenced this pull request Apr 10, 2015
@igalic igalic merged commit 09da0d1 into puppetlabs:master Apr 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants