Allow setting environment variables inside the proxy locations #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1335,12 +1335,14 @@ apache::vhost { 'site.name.fdqn': | |||
| 'params' => { 'retry' => '0', 'timeout' => '5' }, }, | |||
| { 'path' => '/e', 'url' => 'http://backend-a/e', | |||
| 'keywords' => ['nocanon', 'interpolate'] }, | |||
| { 'path' => '/f', 'url' => 'http://backend-f/', 'setenv' => ['proxy-nokeepalive 1','force-proxy-request-1.0 1']}, | |||
There was a problem hiding this comment.
please insert a break here for readability
|
looks much betterer now! |
stevenpost
force-pushed
the
feature/proxy_setenv
branch
from
af4f03c
to
ebf6355
Compare
|
squashed the commits into a single patch |
|
Hi, Do you know why this test fails on travis, only for some environments? https://travis-ci.org/puppetlabs/puppetlabs-apache/builds/54071349 The build is from before the squash, but no actual changes are made with the squash. |
|
nevermind, I see it... the other environments are just taking longer, I made an error in one of the tests, will push an update. |
This patch adds support to set variables using 'SetEnv' inside proxy locations. This is needed to support some backends that don't properly support HTTP/1.1, as it allows a fallback by the Apache httpd server. For details see [1] (Apache httpd documentation) and [2] (use case). [1] http://httpd.apache.org/docs/2.2/mod/mod_proxy.html#envsettings [2] https://wiki.jenkins-ci.org/display/JENKINS/Running+Jenkins+behind+Apache
stevenpost
force-pushed
the
feature/proxy_setenv
branch
from
ebf6355
to
6679778
Compare
igalic
added a commit
that referenced
this pull request
Mar 14, 2015
Allow setting environment variables inside the proxy locations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support to set variables using 'SetEnv' inside proxy
locations. This is needed to support some backends that don't properly
support HTTP/1.1, as it allows a fallback by the Apache httpd server.
For details see [1](Apache httpd documentation) and [2](use case).
[1] http://httpd.apache.org/docs/2.2/mod/mod_proxy.html#envsettings
[2] https://wiki.jenkins-ci.org/display/JENKINS/Running+Jenkins+behind+Apache