[#puppethack] Adding ability to enable/disable the secruleengine through a parameter #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still no tests though, cuz, i'm finding them quite pointless in this case. |
|
@igalic I don't think I ever disagreed. :P I think after looking at the spec tests for mod_security, a unit test is likely not necessary. Will merge once travisci is done. |
|
Can this be merged in? I'd like to be the first test-case :-) |
igalic
added a commit
that referenced
this pull request
Jul 30, 2015
[#puppethack] Adding ability to enable/disable the secruleengine through a parameter
|
yes, yes it can. (now that travis is done) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebase / squash of #1120.