Catch that mod_authz_default has been removed in Apache 2.4 #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class apache::mod::authz_default( | ||
| $apache_version = $::apache::apache_version | ||
| ) { | ||
| if versioncmp($apache_version, '2.4') >= 0 { |
There was a problem hiding this comment.
Could you remove the parameter and just reference $::apache::apache_version directly? I don't think there is any reason for anyone to pass the version in, is there?
There was a problem hiding this comment.
I've seen this in many other subclasses, for example worker.pp, and simply assumed that there must be a good reason that I have too little Puppet knowledge to understand... So what?
|
Could you squash this into one commit? Thanks. |
Having it in the server config will prevent the server from starting as the module file cannot be found.
mpdude
force-pushed
the
no-mod-authz-default-in-2.4
branch
from
26311f8
to
059b92b
Compare
|
Squashed. |
|
ping @hunner |
hunner
added a commit
that referenced
this pull request
Sep 3, 2015
Catch that mod_authz_default has been removed in Apache 2.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having it in the server config will prevent the server from starting as the module file cannot be found.