RewriteLock support #1228
Merged
RewriteLock support #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added ability to define a RewriteLock file in the httpd.conf for apache version 2.2
|
Thanks for catching this oversight! would you mind also adding a test and a doc entry? |
|
done… |
| @@ -55,6 +55,7 @@ | |||
| $conf_template = $::apache::params::conf_template, | |||
| $servername = $::apache::params::servername, | |||
| $pidfile = $::apache::params::pidfile, | |||
| $rewrite_lock = false, | |||
There was a problem hiding this comment.
let's make this undef by default, since we're dealing with a String (path) here.
|
looks very good otherwise, thanks @wickedOne! |
|
thanks for pointing all that out @igalic moved the lockfile to location |
wickedOne
force-pushed
the
rewritelock
branch
from
54b0fb4
to
d38cc4d
Compare
|
\o/ @wickedOne! |
|
thanx @igalic for the super quick merge! ,,/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as addition to the RewriteMap feature i've added the option to define a RewriteLock for apache version <= 2.2 which is considered best practice when using a RewriteMap of type prg