(MODULES-2682) Update Apache Configuration to use FilesMatch instead … #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of AddHandler for PHP Files. The issue with this is that the extension handling behaviour of apache is not well known by most php developers, and many php scripts are open to security issues if this configuration is used (most commonly these scripts handle upload forms which white list image extensions). For example foo.php.jpg will be handled by php. Many distro's no longer use AddHandler in their default config: http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/vivid/php5/vivid/view/head:/debian/php5.conf. The PHP manual also recommends avoiding it: http://php.net/manual/en/install.unix.apache2.php#example-20 This is based on Alejandro Bednarik's <alejandro.bednarik@gmail.com> original fix, I added proper regex escaping, and a changelog entry. All bugs are mine.
|
Thanks @DavidS |
tphoney
added a commit
that referenced
this pull request
Nov 26, 2015
(MODULES-2682) Update Apache Configuration to use FilesMatch instead …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of AddHandler for PHP Files.
The issue with this is that the extension handling behaviour of apache is
not well known by most php developers, and many php scripts are open to
security issues if this configuration is used (most commonly these scripts
handle upload forms which white list image extensions). For example
foo.php.jpg will be handled by php.
Many distro's no longer use AddHandler in their default config:
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/vivid/php5/vivid/view/head:/debian/php5.conf.
The PHP manual also recommends avoiding it:
http://php.net/manual/en/install.unix.apache2.php#example-20
This is based on Alejandro Bednarik's alejandro.bednarik@gmail.com original
fix, I added proper regex escaping, and a changelog entry. All bugs are mine.