Support the mod_proxy ProxPassReverseCookieDomain directive

[occelebi]

Hey,

I've added ProxyPassReverseCookieDomain directive in mod_proxy.

Regards,
Cem

[bmjen]

@occelebi Thanks for the contribution! This PR looks good. It needs a squash, but also.. how come you reviewed the spec test? It would be great if you got that test working so we can validate that the template gets populated correctly.

[occelebi]

@bmjen, It has been squashed. However I do not know how to write proper test for this case as I do not know ruby very well.

[bmjen]

This is misaligned, can you add a space here.

[bmjen]

@occelebi It's pretty simple to add a test case to an existing test. All we're expecting is that if a parameter is set, that the code does what it's intended.

Basically you can add another entry here:

puppetlabs-apache/spec/defines/vhost_spec.rb

Lines 226 to 229 in cf84e97

	'reverse_cookies' => [{
	'path' => '/a',
	'url' => 'http://backend-a/',
	}],

with the domain key.

              'reverse_cookies' => [
                {
                  'path' => '/a',
                  'url'    => 'http://backend-a/',
                },
                {
                  'domain' => 'foo',
                  'url'         => 'http://foo',
               }
             ],

Then you can add another line below here:

puppetlabs-apache/spec/defines/vhost_spec.rb

Lines 432 to 433 in cf84e97

	it { is_expected.to contain_concat__fragment('rspec.example.com-proxy').with_content(
	/ProxyPassReverseCookiePath\s+\/a\s+http:\/\//) }

to match the string output you'd expect based on what you set the domain to.

      it { is_expected.to contain_concat__fragment('rspec.example.com-proxy').with_content(
              /ProxyPassReverseCookieDomain\s+foo\s+http:\/\/foo/) }

[occelebi]

@bmjen Thank you for your guidance. I've pushed new version.

But I'm still in need of clarification for test of ProxyPassReverseCookiePath:

          'reverse_cookies' => [
            {
              'path' => '/a',
              'url'    => 'http://backend-a/',
            },

According to that I expected something like that:

   it { is_expected.to contain_concat__fragment('rspec.example.com-proxy').with_content(
          /ProxyPassReverseCookiePath\s+\/a\s+http:\/\/backend-a\//) }

[bmjen]

Thanks @occelebi ! That test has a loose regex match and passes because it only matches up to the "http://", your suggestion would have been better.