Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve /etc/httpd/conf.d/passenger.conf on EL7 #1345

Merged
merged 1 commit into from
Jan 28, 2016

Conversation

domcleal
Copy link
Contributor

mod_passenger provides a passenger.conf containing PassengerRoot to
ensure the service starts up correctly. On EL7, this is installed at
/etc/httpd/conf.d/passenger.conf and has been protected from purging
since 005bf61.

The change in 2a60859 to move LoadModule config files to
/etc/httpd/conf.modules.d/ on EL7 also affected the path of the
protected passenger.conf. This change reverts the path change to match
the packages.

In summary, prior to 2a60859 (release 1.7.0):

  • /etc/httpd/conf.d/passenger.conf with PassengerRoot (packaged)
  • /etc/httpd/conf.d/passenger_extra.conf with apache::mod::passenger settings
  • /etc/httpd/conf.d/zpassenger.load with LoadModule

In 2a60859 (release 1.8.0):

  • /etc/httpd/conf.modules.d/passenger_extra.conf with apache::mod::passenger settings
  • /etc/httpd/conf.modules.d/zpassenger.load with LoadModule
  • /etc/httpd/conf.d/passenger.conf is purged

With this commit:

  • /etc/httpd/conf.modules.d/passenger_extra.conf with apache::mod::passenger settings
  • /etc/httpd/conf.modules.d/zpassenger.load with LoadModule
  • /etc/httpd/conf.d/passenger.conf with PassengerRoot (packaged)

I targeted this at the 1.8.x branch, as it's a regression in 1.8.0 - is that OK? I assume it'll get merged up to master and possibly put into a patch release this way.

mod_passenger provides a passenger.conf containing PassengerRoot to
ensure the service starts up correctly.  On EL7, this is installed at
/etc/httpd/conf.d/passenger.conf and has been protected from purging
since 005bf61.

The change in 2a60859 to move LoadModule config files to
/etc/httpd/conf.modules.d/ on EL7 also affected the path of the
protected passenger.conf.  This change reverts the path change to match
the packages.

In summary, prior to 2a60859 (release 1.7.0):

- /etc/httpd/conf.d/passenger.conf with PassengerRoot (packaged)
- /etc/httpd/conf.d/passenger_extra.conf with apache::mod::passenger settings
- /etc/httpd/conf.d/zpassenger.load with LoadModule

In 2a60859 (release 1.8.0):

- /etc/httpd/conf.modules.d/passenger_extra.conf with apache::mod::passenger settings
- /etc/httpd/conf.modules.d/zpassenger.load with LoadModule
- /etc/httpd/conf.d/passenger.conf is purged

With this commit:

- /etc/httpd/conf.modules.d/passenger_extra.conf with apache::mod::passenger settings
- /etc/httpd/conf.modules.d/zpassenger.load with LoadModule
- /etc/httpd/conf.d/passenger.conf with PassengerRoot (packaged)
bmjen added a commit that referenced this pull request Jan 28, 2016
Preserve /etc/httpd/conf.d/passenger.conf on EL7
@bmjen bmjen merged commit 4d0c2b9 into puppetlabs:1.8.x Jan 28, 2016
@timogoebel
Copy link
Contributor

@bmjen : Any chance, that this commit gets into master as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants