Don't fail if first element of is not an hash before flattening #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sathieu
force-pushed
the
rewrites_nofail
branch
2 times, most recently
from
4222c50
to
7047f5c
Compare
|
@sathieu thanks for the PR! In what situation would the first element not be a hash? |
|
@eputnam : When the directives param is made from several variables (like [$a, $b,$c]), and some of them are undef, of an array |
|
Looks like |
The template is using [@rewrites].flatten.compact which maps to Puppet's delete_undef_values(flatten([])) Bump stdlib version to the one introducing `delete_undef_values'.
sathieu
force-pushed
the
rewrites_nofail
branch
from
7047f5c
to
e8b9a50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template is using [@rewrites].flatten.compact which maps to Puppet's delete_undef_values(flatten([]))