use Enum instead of validate_re for $sendfile #1664
Conversation
|
I don't see why the tests failed. |
|
parallel_tests maybe? 😹 |
| @@ -636,7 +636,7 @@ | |||
| it "should fail" do | |||
| expect do | |||
| catalogue | |||
| end.to raise_error(Puppet::Error, /"foo" does not match/) | |||
| end.to raise_error(Puppet::PreformattedError, /Evaluation Error: Error while evaluating a Resource Statement, Class\[Apache\]: parameter 'sendfile' expects a match for Enum\['Off', 'On', 'off', 'on'\], got 'foo'/) | |||
There was a problem hiding this comment.
is it still needed to test against those cases? In the Vox Pupuli namespace we dropped them
There was a problem hiding this comment.
I can delete this for sure, if wanted...
| @@ -38,7 +38,7 @@ | |||
| $purge_vhost_dir = undef, | |||
| $purge_vdir = false, | |||
| $serveradmin = 'root@localhost', | |||
| $sendfile = 'On', | |||
| Enum['On', 'Off', 'on', 'off'] $sendfile = 'On', | |||
There was a problem hiding this comment.
why not map On/Off, on/off to bool in puppet?
There was a problem hiding this comment.
For simplification you could add a type Apache::OnOff since this validation is used in a lot of places.
There was a problem hiding this comment.
I can do that, if wanted.
However, that would be a separate PR, which also changes all occurrences of it.
There was a problem hiding this comment.
I think you're right they shouldn't be in this PR.
|
@mmoll if you rebase, do the tests pass then? |
|
Tests are green now. |
|
anything needed to get this in? |
use Enum instead of validate_re for $sendfile
No description provided.