Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various enhancements to apache::mod::passenger #2058

Merged
merged 4 commits into from Aug 10, 2020
Merged

Various enhancements to apache::mod::passenger #2058

merged 4 commits into from Aug 10, 2020

Conversation

smortex
Copy link
Collaborator

@smortex smortex commented Aug 10, 2020 •
edited

This PR improve the support of Passenger with the apache module:

  • Add support for new settings introduced in recent passenger versions;
  • Improve/Fix the way the passenger configuration snippet is included in the vhost configuration files (some parameters where not checked, and the existing checks where not always working as expected with boolean values);
  • Update links to the latest documentation.

@smortex
Compare passenger optional values with undef
dd9f3ac 
An explicit Boolean value 'false' means a passenger setting was
explicitely set, and should not account as the setting being absent.
@smortex
Add missing/new passenger settings
e4bedb4
@smortex
Fix the list of passenger parameters
996a1ae 
Some supported Passenger parameters where not checked for conditional
configuration of passenger, resulting in some configuration being
ignored.

Check all supported parameters and if any is set, include the passenger
configuration snippet.
@smortex smortex requested a review from a team as a code owner August 10, 2020 01:25
@puppet-community-rangefinder
Copy link

apache::mod::passenger is a class

Breaking changes to this file WILL impact these 11 modules (exact match):
Breaking changes to this file MAY impact these 2 modules (near match):

apache::vhost is a type

Breaking changes to this file WILL impact these 125 modules (exact match):
Breaking changes to this file MAY impact these 32 modules (near match):

This module is declared in 174 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@smortex
Update passenger documentation links
7b9ee56 
Point to the latest documentation available.  The old documentation is
not updated in respect to the latest passenger releases, so for
consistency update all links to point to the new documenation.
@smortex smortex mentioned this pull request Aug 10, 2020
Merged
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2020 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (main@86486cb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2058   +/-   ##
=======================================
  Coverage        ?   58.49%           
=======================================
  Files           ?       12           
  Lines           ?      212           
  Branches        ?        0           
=======================================
  Hits            ?      124           
  Misses          ?       88           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86486cb...7b9ee56. Read the comment docs.

sanfrancrisko
sanfrancrisko approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement @smortex !

@sanfrancrisko sanfrancrisko changed the title Various passenger enhancements Various enhancements to apache::mod::passenger Aug 10, 2020
@sanfrancrisko sanfrancrisko merged commit 4ab7e7c into puppetlabs:main Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanfrancrisko sanfrancrisko sanfrancrisko approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smortex @codecov-commenter @sanfrancrisko