Add missing tests for RHEL 8 #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EL7 acceptance tests are failing due to a YUM issue? Definitely not something I touched... |
yakatz
force-pushed
the
feature/broken_icons
branch
2 times, most recently
from
985d58c
to
1ddc30d
Compare
|
Seriously, did I do something that impacts these tests? I am recommitting the same code to force a retest and getting different errors every time... |
yakatz
force-pushed
the
feature/broken_icons
branch
from
1ddc30d
to
ca26a76
Compare
sanfrancrisko
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Thanks for the enhancements @yakatz - LGTM, happy to merge.
Regarding the acceptance test failures, it may have been that your fork was a bit behind puppetlabs:main - I rebased and ran the acceptance tests on my side and all looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.