New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Debian < 8 and Ubuntu < 14.04 code #2189
Conversation
apache::mod::suphp is a classthat may have no external impact to Forge modules. apache::mpm is a typethat may have no external impact to Forge modules. apache::params is a classBreaking changes to this file WILL impact these 16 modules (exact match):Breaking changes to this file MAY impact these 11 modules (near match):apache::version is a classBreaking changes to this file WILL impact these 1 modules (exact match):This module is declared in 175 of 578 indexed public
|
Since this is breaking, I'm interesting in @puppetlabs/modules weighing in. Sadly, I can't ping them. |
@ekohl Thanks for the PR. Its important to remove stale code to keep the maintenance easier. Was talking with the team and looks like platforms is not supported. https://puppet.com/docs/pe/2019.8/supported_operating_systems.html#supported_operating_systems |
@ekohl Will be adding the details about the PR in our this week blog post to inform the community for the major release of this module and its changes. |
@@ -6,7 +6,7 @@ | |||
class apache::mod::suphp ( | |||
) { | |||
if ($facts['os']['name'] == 'Ubuntu' and versioncmp($facts['os']['release']['major'], '15.10') >= 0) or | |||
($facts['os']['name'] == 'Debian' and versioncmp($::operatingsystemrelease, '8') >= 0) { | |||
$facts['os']['family'] == 'Debian' { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now reread this and this looks like a bad rebase from my side. This also drops Ubuntu < 15.10 support here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2193 should fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ekohl for the fixes.
No description provided.