Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Debian < 8 and Ubuntu < 14.04 code #2189

Merged
merged 1 commit into from Sep 13, 2021

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Sep 2, 2021

No description provided.

@ekohl ekohl requested a review from a team as a code owner September 2, 2021 11:27
@puppet-community-rangefinder
Copy link

apache::mod::suphp is a class

that may have no external impact to Forge modules.

apache::mpm is a type

that may have no external impact to Forge modules.

apache::params is a class

Breaking changes to this file WILL impact these 16 modules (exact match):
Breaking changes to this file MAY impact these 11 modules (near match):

apache::version is a class

Breaking changes to this file WILL impact these 1 modules (exact match):

This module is declared in 175 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@ekohl
Copy link
Collaborator Author

ekohl commented Sep 2, 2021

Since this is breaking, I'm interesting in @puppetlabs/modules weighing in. Sadly, I can't ping them.

@sheenaajay
Copy link
Contributor

sheenaajay commented Sep 6, 2021

@ekohl Thanks for the PR. Its important to remove stale code to keep the maintenance easier. Was talking with the team and looks like platforms is not supported. https://puppet.com/docs/pe/2019.8/supported_operating_systems.html#supported_operating_systems
But it will definitely break existing users. We need to inform community in advance about the release of major version and its impact. Thank you.

@sheenaajay
Copy link
Contributor

@ekohl Will be adding the details about the PR in our this week blog post to inform the community for the major release of this module and its changes.

@sheenaajay sheenaajay merged commit 7d19d25 into puppetlabs:main Sep 13, 2021
@ekohl ekohl deleted the drop-old-deb branch September 13, 2021 10:34
@@ -6,7 +6,7 @@
class apache::mod::suphp (
) {
if ($facts['os']['name'] == 'Ubuntu' and versioncmp($facts['os']['release']['major'], '15.10') >= 0) or
($facts['os']['name'] == 'Debian' and versioncmp($::operatingsystemrelease, '8') >= 0) {
$facts['os']['family'] == 'Debian' {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now reread this and this looks like a bad rebase from my side. This also drops Ubuntu < 15.10 support here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2193 should fix that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ekohl for the fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants