pdksync - (GH-cat-11) Certify Support for Ubuntu 22.04 #2276
Conversation
|
Ah, this is just a blanket PR to add to all the metadata's |
|
I know, just linking up related issues. |
david22swan
force-pushed
the
pdksync_GH-cat-11/main/add_ubuntu_22.04_support
branch
4 times, most recently
from
b9e8a6e
to
7628202
Compare
manifests/params.pp
Outdated
| if ($facts['os']['name'] == 'Ubuntu' and versioncmp($facts['os']['release']['major'], '22.04') < 0) or | ||
| ($facts['os']['name'] == 'Debian' and versioncmp($facts['os']['release']['major'], '11') < 0) { |
There was a problem hiding this comment.
Indenting looks odd here. Would this work better with the lint plugin?
| if ($facts['os']['name'] == 'Ubuntu' and versioncmp($facts['os']['release']['major'], '22.04') < 0) or | |
| ($facts['os']['name'] == 'Debian' and versioncmp($facts['os']['release']['major'], '11') < 0) { | |
| if (($facts['os']['name'] == 'Ubuntu' and versioncmp($facts['os']['release']['major'], '22.04') < 0) or | |
| ($facts['os']['name'] == 'Debian' and versioncmp($facts['os']['release']['major'], '11') < 0)) { |
There was a problem hiding this comment.
Have added the extra circle brackets.
As for the indent while I agree that what you suggested look's better, the syntax check throws a warning at it unfortunately.
There was a problem hiding this comment.
Alternative:
if (
($facts['os']['name'] == 'Ubuntu' and versioncmp($facts['os']['release']['major'], '22.04') < 0) or
($facts['os']['name'] == 'Debian' and versioncmp($facts['os']['release']['major'], '11') < 0)
) {
# code here
}
david22swan
force-pushed
the
pdksync_GH-cat-11/main/add_ubuntu_22.04_support
branch
from
7628202
to
f9710ef
Compare
| if (($facts['os']['name'] == 'Ubuntu' and versioncmp($facts['os']['release']['major'], '22.04') < 0) or | ||
| ($facts['os']['name'] == 'Debian' and versioncmp($facts['os']['release']['major'], '11') < 0)) { |
There was a problem hiding this comment.
I did create os_version_gte for this in the past, but never got around to using it. If you want, you could rewrite the logic here. Be sure to use at least stdlib 8.1.0 then since that fixed the logic.
There was a problem hiding this comment.
While that function looks like a good idea, doing this would require that a major release be made as we would need to bump the current lower stdlib version bound (it's currently 4.13.1), so I think it may be best to leave as is for now.
There was a problem hiding this comment.
I get you may consider it too large, but normally I don't consider increasing the minimum version a reason for a major version bump. Though 8.1.0 is recentish for stdlib (~1 year old).
(GH-cat-11) Certify Support for Ubuntu 22.04
pdk version:
2.4.0