Remove firewall resource

[hunner]

The firewall declarations should not be handled by the apache module

[pronix]

hello
where should be firewall declaration ?

[bmurtagh]

I think the firewall should be declared in another module specific for firewall rules or a wrapper. The Apache module should focus on all things related to Apache setup, configuration, and management. A separate firewall module/wrapper would include all rules needed to grant access for that node or infrastructure. It should be referenced/included/chained by your module containing Apache if needed.

[hunner]

@bmurt is correct. The apache module and all of its classes and defines are not given the responsibility of understanding the firewall requirements of every company, and so shouldn't make assumptions about requirements.

Usually pairing the firewall resources that work for you with the apache::vhost resources in a single define that understands your business logic and data binding is the current practice.

[bmurtagh]

@hunner Are you going to be attempting the build again to get this merged?

[hunner]

@hunner Are you going to be attempting the build again to get this merged?

The builds ran successfully. I was just hoping for a little feedback, since I'm currently a one-man team and can't peer-review my own code :P. I'll take this as a "+1" and merge it.