Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add balancermember define #238

Merged
merged 1 commit into from
Jul 3, 2013
Merged

Conversation

tjikkun
Copy link
Contributor

@tjikkun tjikkun commented Jun 25, 2013

No description provided.

@hunner
Copy link
Contributor

hunner commented Jul 1, 2013

Thanks for updating this PR @tjikkun. (For reference, the original was #237.) Just a note; you can push commits to the same branch and it will update this PR with changes.

What do you think about wrapping the concat target and fragments with an apache::balancer defined resource or something similar to haproxy::listen so that users can more easily set up the front-end node? And then we don't have to worry about what target to set on apache::balancermember because it can work like haproxy::balancermember and give a similar API where the target is based on the name of the cluster, not the path of the file.

It would be awesome to see the apache module support a pre-packaged load balancer setup, and this looks like it is headed in the right direction :).

@tjikkun
Copy link
Contributor Author

tjikkun commented Jul 2, 2013

Hi @hunner, thanks for your comments. I knew about the pushing but wasn't sure the PR would be re-opened by that.
Anyway I gave your suggestions a try. I am sure some functionality can be added, but I think this will provide a good base. Looking forward to your comments.

Now apache can be used as a loadbalancer :)
@hunner
Copy link
Contributor

hunner commented Jul 3, 2013

This is pretty sweet! Thanks :)

Now just spec tests ;)

hunner added a commit that referenced this pull request Jul 3, 2013
@hunner hunner merged commit fb9d353 into puppetlabs:master Jul 3, 2013
@tjikkun tjikkun deleted the balancermember branch July 15, 2013 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants