New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise Puppet lower bound to >= 7.9.0 #2444
Conversation
Looks fine (4190789 introduced such changes a while ago), but your link says it was part of Puppet 7.9.0, not 7.10.0. Was there some issue that prevented this from working correctly in 7.9.0 or is it a typo? |
Similar to eb5b4c0 this module uses PUP-5704[1] which was only introduced in Puppet 7.9.0. [1]: https://www.puppet.com/docs/puppet/7/release_notes_puppet.html#enhancements_puppet_x-7-9-0-PUP-5704 Fixes: 8070478 ("(CONT-772) Update metadata.json and Gemfile")
Good catch. Not a typo, but I used |
46e15e9
to
186c729
Compare
Wanted to get more context around |
@Ramesh7 I'm not sure what you're exactly asking, but the ability to pass an array was only added in Puppet 7.9.0 (and Puppet 6.24.0). So you can't use this module with Puppet 7.8.0. The version_requirement should reflect that. |
Looks like I was checking on Puppet 6.28, which has this implemented and that's where I must have confused that as its already there. |
It is confusing that it's >= 6.24 < 7, >= 7.9. I've removed the backwards-incompatible label because it's not. It's just clarifying what was previously implicit. I'd consider this a bugfix. |
Similar to eb5b4c0 this module uses PUP-5704 which was only introduced in Puppet 7.10.0.
Fixes: 8070478 ("(CONT-772) Update metadata.json and Gemfile")