Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise Puppet lower bound to >= 7.9.0 #2444

Merged
merged 3 commits into from Sep 15, 2023

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Aug 18, 2023

Similar to eb5b4c0 this module uses PUP-5704 which was only introduced in Puppet 7.10.0.

Fixes: 8070478 ("(CONT-772) Update metadata.json and Gemfile")

bastelfreak
bastelfreak previously approved these changes Aug 21, 2023
@smortex
Copy link
Collaborator

smortex commented Aug 21, 2023

Looks fine (4190789 introduced such changes a while ago), but your link says it was part of Puppet 7.9.0, not 7.10.0. Was there some issue that prevented this from working correctly in 7.9.0 or is it a typo?

Similar to eb5b4c0 this module uses
PUP-5704[1] which was only introduced in Puppet 7.9.0.

[1]: https://www.puppet.com/docs/puppet/7/release_notes_puppet.html#enhancements_puppet_x-7-9-0-PUP-5704

Fixes: 8070478 ("(CONT-772) Update metadata.json and Gemfile")
@ekohl
Copy link
Collaborator Author

ekohl commented Aug 21, 2023

Good catch. Not a typo, but I used git tag --contains 59d045bb65260b7e9c5bf979da2bd7421cebfbaf which doesn't sort like versions by default, so 7.10 shows up before 7.9. Updated now.

@ekohl ekohl changed the title Raise Puppet lower bound to >= 7.10.0 Raise Puppet lower bound to >= 7.9.0 Aug 21, 2023
@Ramesh7
Copy link
Contributor

Ramesh7 commented Sep 14, 2023

Wanted to get more context around exec's command (only for *.nix) along with unless and onlyif arguments were already accepting array and as part of 419078 only see above arguments changed to array which was already supported in older version as well.
I am sure I am missing something here so please help me to get missing piece and also correct if my understanding is not right.

@ekohl
Copy link
Collaborator Author

ekohl commented Sep 14, 2023

@Ramesh7 I'm not sure what you're exactly asking, but the ability to pass an array was only added in Puppet 7.9.0 (and Puppet 6.24.0). So you can't use this module with Puppet 7.8.0. The version_requirement should reflect that.

@Ramesh7
Copy link
Contributor

Ramesh7 commented Sep 15, 2023

@Ramesh7 I'm not sure what you're exactly asking, but the ability to pass an array was only added in Puppet 7.9.0 (and Puppet 6.24.0). So you can't use this module with Puppet 7.8.0. The version_requirement should reflect that.

Looks like I was checking on Puppet 6.28, which has this implemented and that's where I must have confused that as its already there.

@Ramesh7 Ramesh7 merged commit abb8410 into puppetlabs:main Sep 15, 2023
75 checks passed
@ekohl ekohl deleted the raise-puppet-version branch September 15, 2023 13:10
@ekohl
Copy link
Collaborator Author

ekohl commented Sep 15, 2023

It is confusing that it's >= 6.24 < 7, >= 7.9. I've removed the backwards-incompatible label because it's not. It's just clarifying what was previously implicit. I'd consider this a bugfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants