Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop managing mime support package on Debian #2526

Merged
merged 1 commit into from Apr 2, 2024

Conversation

jcharaoui
Copy link
Contributor

@jcharaoui jcharaoui commented Feb 20, 2024

Summary

All apache2 packages on Debian 10 and later already have a hard dependency on the mime-support package. While mime-support still exists on Debian 12 as a transitonal package, upcoming Debian 13 has removed it entirely.

This sets the $mime_support_package to undefined so that the package isn't managed on Debian, since it doesn't need to be.

Additional Context

Currently, the module fails completely on Debian testing (upcoming release 13 codenamed trixie):

Error: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install mime-support' returned 100: Reading package lists...                                                                          
Building dependency tree...                                                                                                                                                                                          
Reading state information...                                                                                                                                                                                         
Package mime-support is not available, but is referred to by another package.                                                                                                                                        
This may mean that the package is missing, has been obsoleted, or                                                                                                                                                    
is only available from another source                                                                                                                                                                                
However the following packages replace it:                                                                                                                                                                           
  media-types mailcap                                                                                                                                                                                                
                                                                                                                                                                                                                     
E: Package 'mime-support' has no installation candidate                                                                                                                                                              
Error: /Stage[main]/Apache::Mod::Mime/Package[mime-support]/ensure: change from 'purged' to 'present' failed: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install mime-support' returned 
100: Reading package lists...                                                                                                                                                                                        
Building dependency tree...                                                                                                                                                                                          
Reading state information...                                                                                                                                                                                         
Package mime-support is not available, but is referred to by another package.                                                                                                                                        
This may mean that the package is missing, has been obsoleted, or                                                                                                                                                    
is only available from another source                                                                                                                                                                                
However the following packages replace it:                                                                                                                                                                           
  media-types mailcap                                                                                                                                                                                                
                                                                                                                                                                                                                     
E: Package 'mime-support' has no installation candidate                                                                                                                                                              
Notice: /Stage[main]/Apache::Mod::Mime/File[mime.conf]: Dependency Package[mime-support] has failures: true

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

All apache2 packages on Debian 10 and later already have a hard dependency on
the `mime-support` package. While `mime-support` still exists on Debian 12
as a transitonal package, upcoming Debian 13 has removed it entirely.

This sets the `$mime_support_package` to undefined so that the package
isn't managed on Debian, since it doesn't need to be.
@TheMeier
Copy link

IMHO the default should stay unchanged for Debian 11 and 12 for the time being. So maybe add something like this in params.pp:

if ($facts['os']['name'] == 'Debian' and versioncmp($facts['os']['release']['major'], '13') < 0) {...

@ekohl
Copy link
Collaborator

ekohl commented Mar 23, 2024

IMHO the default should stay unchanged for Debian 11 and 12 for the time being. So maybe add something like this in params.pp:

Why, if the packaging already has a hard dependency then why not rely on that?

@jcharaoui
Copy link
Contributor Author

Accepting this change will allow Debian 12 users to get rid of the transitional, dummy package mime-support on their systems.

@TheMeier
Copy link

IMHO the default should stay unchanged for Debian 11 and 12 for the time being. So maybe add something like this in params.pp:

Why, if the packaging already has a hard dependency then why not rely on that?

Sorry, misunderstanding no my side please ignore my comment

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved CI, so waiting on that to finish.

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane!

@ekohl ekohl merged commit dcc3072 into puppetlabs:main Apr 2, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants