Auth #289
Merged
Auth #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Directives: * auth_type * auth_name * auth_digest_algorithm * auth_digest_domain * auth_digest_nonce_lifetime * auth_digest_provider * auth_digest_qop * auth_digest_shmem_size * auth_basic_authoritative * auth_basic_fake * auth_basic_provider * auth_user_file * auth_require This patch is still incomplete. E.g. directives for authentication providers and authorization are missing.
|
This looks awesome! This is more along the lines of what I was hoping for :). Thanks for putting in the time to make this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would love to discuss these changes with you.
The template for the directories contains more general directives/template parameters which allow you to use basic auth as well as digest auth. Somehow this pull requests reverts the latests changes on this topic.
I also tried to add syntax highlighting to the README and added documentation about the auth directives.
Best Regards
Philipp